Environ secrets #356
Merged
Environ secrets #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlov721
requested review from
conorsim,
klemen1999 and
tersekmatija
and removed request for
a team
github-actions
bot
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 103 104 +1
Lines 6333 6341 +8
=======================================
+ Hits 6033 6041 +8
Misses 300 300 ☔ View full report in Codecov by Sentry. |
klemen1999
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
More secure way of storing secrets loaded from the environment.
Specification
luxonis_ml.utils.environtoSecretStrDependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
Added new tests to
test_environ.pyfile